Gilad Chaplik has posted comments on this change. Change subject: engine: allow to fetch all QoS for REST ......................................................................
Patch Set 13: (2 comments) lets change the 'small things' before merging.. replied to your comments :) http://gerrit.ovirt.org/#/c/28767/13/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosBase.java: Line 62: * @param other Line 63: * @return are equals Line 64: */ Line 65: public boolean equalValues(QosBase other) { Line 66: return false; > i know why you had to implement it, the question is why to return false her since this class isn't abstract, and it has no values, there is no need for this method ; but, when overriding it, you must override this method. so I think for the sake of safety, be can return false. what do you think? Line 67: } Line 68: Line 69: @Override Line 70: public Guid getId() { http://gerrit.ovirt.org/#/c/28767/13/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/AllQosBaseDaoFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/AllQosBaseDaoFacadeImpl.java: Line 12: Line 13: public class AllQosBaseDaoFacadeImpl extends QosBaseDaoFacadeImpl<QosBase> implements QosBaseDao { Line 14: Line 15: public AllQosBaseDaoFacadeImpl() { Line 16: super(QosType.ALL); > to avoid adding this value I prefer to add ALL, I'd like to add later on a ui view for it (like in rest) Line 17: } Line 18: Line 19: @Override Line 20: /** -- To view, visit http://gerrit.ovirt.org/28767 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e55d3e7643c42f48c971400b15f6eb92e50ccaa Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
