Yair Zaslavsky has posted comments on this change. Change subject: utils: ovf: move compat xml to ovf as it is the only consumer ......................................................................
Patch Set 3: Code-Review+2 I would consider to remove as much as possible from the XML related code of compat. There are other xml utilities that can be used, too bad we invtented the wheel + i don't see why not to use the W3C classes that come with the jdk, but that's just me, and this should be done in a separate patch. -- To view, visit http://gerrit.ovirt.org/30974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae2b6e697f82702cfb211c670a079f2da14994de Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
