Juan Hernandez has posted comments on this change.
Change subject: build: use maven deploy and move jar handling to Makefile
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(6 inline comments)
....................................................
File Makefile
Line 28: javadir=/usr/share/java
Ok.
Line 68: $(BUILD_FILE):
I still don't see why we need the file. Can't we use just a "build" target? In
understand the having the file avoids doing the build repeatedly if we invoke
"make all" repeatedly, but we don't do that, as far as I understand.
Adding tmp.* to .gitignore is fine by me.
Line 87: all \
Lets trust make masters then.
Line 173: install -p -m 644 "$$POM"
$(PREFIX)$(mavenpomdir)/JPP.ovirt-engine-$$artifact_id.pom; \
Yes, please, as we are trying to make this distribution independent better make
it jpackage independent as well.
Line 175: done
Deal.
....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 312: make PREFIX=%{buildroot} javadir=%{_javadir}
mavenpomdir=%{_mavenpomdir} install
But this is automake convention, as you said, so I will buy eye cleanser.
--
To view, visit http://gerrit.ovirt.org/6171
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eb8b8f60f2be71b2054582b5e898ae996f324ac
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
