Idan Shaby has posted comments on this change. Change subject: core: WAD should be Ignored on File Domain Disks ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/30706/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java: Line 327: // disks is marked with wipe_after_delete Line 328: boolean isDiskWithWipeAfterDeleteExist = Line 329: MemoryImageRemover.isDiskWithWipeAfterDeleteExist(getDiskDao().getAllForVm(getVm().getId())); Line 330: StorageType storageType = getStorageDomainDAO().get( Line 331: MemoryImageRemover.getStorageDomainId(guids)).getStorageType(); > i think storage domain here can return null on some corner cases If the storage domain is null, then there are no memory volumes to remove -> nothing should be done. See the fix in patch set 6. Line 332: boolean postZero = ImagesHandler.shouldWipeAfterDelete(isDiskWithWipeAfterDeleteExist, storageType); Line 333: Line 334: Guid taskId1 = persistAsyncTaskPlaceHolder(parentCommand, DELETE_PRIMARY_IMAGE_TASK_KEY); Line 335: -- To view, visit http://gerrit.ovirt.org/30706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8a9932725ef861525f5102e8617938f0e0a71c7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
