anmolbabu has posted comments on this change. Change subject: engine: gluster volume geo replication entities ......................................................................
Patch Set 15: (6 comments) http://gerrit.ovirt.org/#/c/29605/15/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepCrawlStatus.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepCrawlStatus.java: Line 5: CHANGELOG_CRAWL, Line 6: UNKNOWN, Line 7: HYBRID_CRAWL; Line 8: Line 9: public static GeoRepCrawlStatus getEnumFromString(String crawlStatus) { > Why not call this "forValue"? You meant fromValue as in VmStatus.java Ok, I'll change it Line 10: for(GeoRepCrawlStatus status : values()) { Line 11: if(status.toString().equalsIgnoreCase(crawlStatus)) { Line 12: return status; Line 13: } http://gerrit.ovirt.org/#/c/29605/15/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepSessionStatus.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepSessionStatus.java: Line 9: PARTIAL_FAULTY, Line 10: UNKNOWN, Line 11: FAULTY; Line 12: Line 13: public static GeoRepSessionStatus getEnumFromString(String enumName) { > same Done Line 14: for(GeoRepSessionStatus status : values()) { Line 15: if(status.toString().equalsIgnoreCase(enumName)) { Line 16: return status; Line 17: } http://gerrit.ovirt.org/#/c/29605/15/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSession.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSession.java: Line 107: if (obj == null) Line 108: return false; Line 109: if (getClass() != obj.getClass()) Line 110: return false; Line 111: GlusterGeoRepSession other = (GlusterGeoRepSession) obj; > is this auto generated by Eclipse of intelli-j? :) Yes this is generated by eclipse.Done, I'll change this too :D Line 112: if (masterVolumeId == null) { Line 113: if (other.masterVolumeId != null) Line 114: return false; Line 115: } else if (!masterVolumeId.equals(other.masterVolumeId)) http://gerrit.ovirt.org/#/c/29605/15/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionConfiguration.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionConfiguration.java: Line 4: Line 5: import org.ovirt.engine.core.common.utils.ObjectUtils; Line 6: import org.ovirt.engine.core.compat.Guid; Line 7: Line 8: public class GlusterGeoRepSessionConfiguration implements Serializable{ > this is not business entity? it should not extend the BusinessEntity interf Done Line 9: Line 10: private static final long serialVersionUID = -6506417314359159692L; Line 11: Line 12: Guid sessionId; Line 38: } Line 39: Line 40: @Override Line 41: public boolean equals(Object obj) { Line 42: return (obj != null) && (obj instanceof GlusterGeoRepSessionConfiguration) && ObjectUtils.objectsEqual(getSessionId(), ((GlusterGeoRepSessionConfiguration) obj).getSessionId()) && > So here you do use ObjectUtils. I was probably a bit too lazzy writing it for that class. :D I'll change it Line 43: ObjectUtils.objectsEqual(getKey(), ((GlusterGeoRepSessionConfiguration) obj).getKey()) && Line 44: ObjectUtils.objectsEqual(getValue(), ((GlusterGeoRepSessionConfiguration) obj).getValue()); Line 45: } Line 46: http://gerrit.ovirt.org/#/c/29605/15/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionDetails.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionDetails.java: Line 5: Line 6: import org.ovirt.engine.core.common.utils.ObjectUtils; Line 7: import org.ovirt.engine.core.compat.Guid; Line 8: Line 9: public class GlusterGeoRepSessionDetails implements Serializable{ > same questions as before Done Line 10: Line 11: private static final long serialVersionUID = -8084667500866439692L; Line 12: Line 13: private Guid sessionId; -- To view, visit http://gerrit.ovirt.org/29605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If86abee9276b8f2e4bdd4a4276dbbd76b9514c68 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
