Roy Golan has posted comments on this change. Change subject: core: migrating-to is a running state as well ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31204/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java: Line 93: * returns false Line 94: * Line 95: * @return true if this status indicates that the VM is running for sure, otherwise false Line 96: */ Line 97: public boolean isRunning() { this affects every call to VM.isRunning() - I'm not sure its adequate for each case. can you check? Line 98: return this == Up || this == PoweringDown Line 99: || this == PoweringUp || this == MigratingFrom || this == MigratingTo || this == WaitForLaunch || this == RebootInProgress; Line 100: } Line 101: -- To view, visit http://gerrit.ovirt.org/31204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39403915fa17439224176fc4e5c065311142485a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
