Allon Mureinik has posted comments on this change. Change subject: core: [WIP]Use correct validation for SD selection ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/31488/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java: Line 142: Line 143: public List<DiskImage> getDisksToBeCreated() { Line 144: DiskImage imageForMemory = new DiskImage(); Line 145: imageForMemory.setDiskAlias("memory"); Line 146: //imageForMemory.setStorageIds(new ArrayList<Guid>(Collections.singletonList(storageDomainId))); Please remove instead of commenting out. Line 147: imageForMemory.setStoragePoolId(storagePool.getId()); Line 148: imageForMemory.setSize(vm.getTotalMemorySizeInBytes()); Line 149: imageForMemory.setActualSizeInBytes(vm.getTotalMemorySizeInBytes()); Line 150: //imageForMemory.setVolumeType(getVolumeTypeForDomain()); Line 146: //imageForMemory.setStorageIds(new ArrayList<Guid>(Collections.singletonList(storageDomainId))); Line 147: imageForMemory.setStoragePoolId(storagePool.getId()); Line 148: imageForMemory.setSize(vm.getTotalMemorySizeInBytes()); Line 149: imageForMemory.setActualSizeInBytes(vm.getTotalMemorySizeInBytes()); Line 150: //imageForMemory.setVolumeType(getVolumeTypeForDomain()); Please remove instead of commenting out. Line 151: imageForMemory.setvolumeFormat(VolumeFormat.RAW); Line 152: imageForMemory.getSnapshots().add(imageForMemory); Line 153: Line 154: DiskImage imageForMetadata = new DiskImage(); -- To view, visit http://gerrit.ovirt.org/31488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac901a638358b9b08bcc6992d783a42cbfcd9bfa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
