Oved Ourfali has posted comments on this change.

Change subject: core: Skip fencing if host has connectivity issues
......................................................................


Patch Set 10: -Code-Review

After discussing with Martin on the phone, I think that his comments with 
regards to the location of the logic that determines whether to fence or not, 
should all reside in the canDoAction of the VdsNotRespondingCommand, rather 
than in VdsEventListener.
Please see his patches for an example for that.

Change your patch properly.

-- 
To view, visit http://gerrit.ovirt.org/31303
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a9c7db43b50421414ce9596137767b00cbfc2ae
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin PeÅ™ina <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to