Lior Vernia has posted comments on this change. Change subject: webadmin: Change status panel before command execution ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31282/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java: Line 222: currentCandidate = candidate; Line 223: currentOp1 = op1; Line 224: currentOp2 = op2; Line 225: getOperationCandidateEvent().raise(this, new OperationCadidateEventArgs(candidate, op1, op2, drop)); Line 226: if (drop) { > Is there still any use for the drop on the OperationCadidateEventArgs? You are correct, ever since the red coloring started happening prior to dropping, this has no usage. Line 227: onOperation(candidate, candidate.getCommand(op1, op2, allNics)); Line 228: } Line 229: } Line 230: return !candidate.isNullOperation(); -- To view, visit http://gerrit.ovirt.org/31282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b1ee2481e6596b7c4bbd1f94b826127b57f2c5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
