Allon Mureinik has posted comments on this change.
Change subject: core: Add procedure to get active Hosts per Data Center
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
minor comment, see inline
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDAOTest.java
Line 19: private final Guid STORAGE_POOL_ID = new
Guid("6d849ebf-755f-4552-ad09-9a090cda105d");
should be static,
Also, consider moving it to FixturesTool
--
To view, visit http://gerrit.ovirt.org/6144
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88a820dc87e9b2178a4ef99a2e22762d1824bfb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
