Mike Kolesnik has posted comments on this change.
Change subject: core: Validate the connectivity timeout for SetupNetworks
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetupNetworksParameters.java
Line 23: message = "VALIDATION.CONNECTIVITY.TIMEOUT.RANGE.INVALID")
I think no need to write RANGE in the message key, since the value is what's
not valid, not the range.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1387: NetworkConnectivityCheckTimeoutInSeconds(367),
Duplicate int value as previous config
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 568: VALIDATION.CONNECTIVITY.TIMEOUT.RANGE.INVALID=Connectivity timeout
range is not valid. Range must be between 1 and 120.
The message is not clear, as if the user is specifying a range but the range
itself is not valid..
I think it can be better phrased as something like:
Connectivity timeout value is invalid. Valid values are between 1 and 120.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java
Line 113: if (connectivityTimeout <= 0) {
Why is this still needed?
We don't trust other half of engine? ;)
--
To view, visit http://gerrit.ovirt.org/6200
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e03ec8dc60710780df9bf7b711d639b8c80327e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
