Omer Frenkel has posted comments on this change. Change subject: engine: gluster volume geo replication entities ......................................................................
Patch Set 20: (1 comment) http://gerrit.ovirt.org/#/c/29605/20/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepCrawlStatus.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepCrawlStatus.java: Line 5: CHANGELOG_CRAWL, Line 6: UNKNOWN, Line 7: HYBRID_CRAWL; Line 8: Line 9: public static GeoRepCrawlStatus fromValue(String crawlStatus) { if you plan to save the enum name in the as string, i dont think this method is needed at all, because enum already knows to get enum value from string with 'valueOf()' method Line 10: for(GeoRepCrawlStatus status : values()) { Line 11: if(status.toString().equalsIgnoreCase(crawlStatus)) { Line 12: return status; Line 13: } -- To view, visit http://gerrit.ovirt.org/29605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If86abee9276b8f2e4bdd4a4276dbbd76b9514c68 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
