Tal Nisan has uploaded a new change for review.

Change subject: core: Remove volume & format check on import VM command
......................................................................

core: Remove volume & format check on import VM command

There's no reason to check validaty of the import VM parameters when not
using collapse snapshots since the image format will be determined by the
command itself according to the destination format

Change-Id: I06dc245db032a427d3aa36f62eaae8edcf93f657
Bug-Url: https://bugzilla.redhat.com/1130761
Signed-off-by: Tal Nisan <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/60/31560/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
index 5540e81..ea90db6 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
@@ -288,11 +288,6 @@
                             break;
                         }
                     }
-                } else {
-                    // If no copy collapse sent, validate each image 
configuration (snapshot or active image).
-                    if (!validateImageConfig(canDoActionMessages, domainsMap, 
image)) {
-                        return false;
-                    }
                 }
 
                 image.setStoragePoolId(getParameters().getStoragePoolId());


-- 
To view, visit http://gerrit.ovirt.org/31560
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I06dc245db032a427d3aa36f62eaae8edcf93f657
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to