Shahar Havivi has uploaded a new change for review. Change subject: ui: redundant call to vminit when initializing vms template ......................................................................
ui: redundant call to vminit when initializing vms template When setting vminit to desktop vm (one that have a template), we call again vminit.init() method - after it has been initialize with the right values. Removing that not influence current code work-flow (ie vm, template and pool) Change-Id: Idc2e40f72b85cd3641c6e5c705438cd217308f91 Bug-Url: https://bugzilla.redhat.com/1126195 Signed-off-by: Shahar Havivi <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/00/31600/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java index d9b9e32..fd5268c 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java @@ -759,9 +759,6 @@ model.getTemplate().setItems(Collections.singletonList(template)); model.getTemplate().setSelectedItem(template); model.getTemplate().setIsChangable(false); - if (!template.getId().equals(Guid.Empty)) { - getModel().getVmInitModel().init(template); - } } }, getModel().getHash() -- To view, visit http://gerrit.ovirt.org/31600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idc2e40f72b85cd3641c6e5c705438cd217308f91 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
