Arik Hadas has posted comments on this change.
Change subject: core: Fix NPE on ChangeCD with 'Down' VM
......................................................................
Patch Set 1:
(1 comment)
by organize I mean to have the structure of:
if (...) {
return failCanDoAction(...);
}
...
if (...) {
return failCanDoAction(...);
}
return true;
http://gerrit.ovirt.org/#/c/31614/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java:
Line 41: retValue = false;
Line 42: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__VM);
Line 43:
Line 44: // An empty 'cdImagePath' means eject CD
Line 45: if (!StringUtils.isEmpty(cdImagePath)) {
> No it is not necessary since we are checking if we were given "blabla.iso"
correct me if I'm wrong but cdImagePath is set only in #65, and here and in
line 54 we're checking it so it will always be null in those places, no?
Line 46:
addCanDoActionMessage(VdcBllMessages.VAR__ACTION__CHANGE_CD);
Line 47: } else {
Line 48:
addCanDoActionMessage(VdcBllMessages.VAR__ACTION__EJECT_CD);
Line 49: }
--
To view, visit http://gerrit.ovirt.org/31614
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3bf10dbeb8dd645a515dc140bd9081dc1d1acab
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
