Idan Shaby has posted comments on this change. Change subject: engine: Forbid Bootable and Shareable Disks ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/31142/8/packaging/dbscripts/upgrade/03_06_0230_update_disk_bootable_sharable.sql File packaging/dbscripts/upgrade/03_06_0230_update_disk_bootable_sharable.sql: Line 1: -- Since we don't allow disks to be both bootable and sharable, > was fine before :) s/sharable/shareable Done Line 2: -- we need to set these disks "boot" value to false in base_disks, Line 3: -- and boot_order to 0 in vm_device. Line 4: Line 5: UPDATE vm_device Line 1: -- Since we don't allow disks to be both bootable and sharable, Line 2: -- we need to set these disks "boot" value to false in base_disks, Line 3: -- and boot_order to 0 in vm_device. Line 4: > what about the transaction handling from patch-set 6? Eli said that all the scripts already run in transactions so it's not necessary. Line 5: UPDATE vm_device Line 6: SET boot_order = 0 Line 7: WHERE device_id IN (SELECT disk_id Line 8: FROM base_disks -- To view, visit http://gerrit.ovirt.org/31142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e221d6534b71db96d0c58442220d249b305079b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
