Frank Kobzik has posted comments on this change. Change subject: engine: GraphicsInfo in entities ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/28569/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java: Line 74: private VmExitReason exitReason; Line 75: private int guestCpuCount; Line 76: @UnchangeableByVdsm Line 77: private String overridenConsoleAddress; Line 78: private String vdsHostName; > what are these? This are remains of my previous work that I forgot to clean. I'll fix that! Line 79: private Map<GraphicsType, GraphicsInfo> graphicsInfos; Line 80: Line 81: public static final String APPLICATIONS_LIST_FIELD_NAME = "appList"; Line 82: public static final String STATUS_FIELD_NAME = "status"; Line 75: private int guestCpuCount; Line 76: @UnchangeableByVdsm Line 77: private String overridenConsoleAddress; Line 78: private String vdsHostName; Line 79: private Map<GraphicsType, GraphicsInfo> graphicsInfos; > not sure about the map (i didnt see how it used yet..) but since we know it I used it because working with it is often easier than having something specialized. E.g. it's possible to iterate through it easily (which is what I do in later patches :) ). Also if I embed GraphicsType to GraphicsInfo direcly, I'll lose the ability of easily getting GraphicsInfo by type. Anyway - I'll try to think to consider pros/cons and I'll keep you up to date. Line 80: Line 81: public static final String APPLICATIONS_LIST_FIELD_NAME = "appList"; Line 82: public static final String STATUS_FIELD_NAME = "status"; Line 83: -- To view, visit http://gerrit.ovirt.org/28569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib11a8b63e76031f3137f2dfd0cd6551e9c19aca0 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
