Michael Pasternak has posted comments on this change. Change subject: cli: No regular expression for IP, UUID or number ......................................................................
Patch Set 1: Code-Review+2 Juan, 1. when i'm saying that by this change you killing feature that forces arguments validation, i don't ask for lexer to become greedy, in cli there is an infra which validates that option.value type matches constraint defined in command, and since text-processor capable of interpretating incoming string in to it actual type, this feature can work on this option.value as is, now when you make everything /WORD (i.e string), to make this feature work, you'll have to try and cast to the type defined in constraint & catching exception ... 2. obviously there is many more flows where you want to get option.value in it actual type rather than casting to it later (every time it referenced) i won't continue stopping from you to proceed, but i'm still convinced that you "making the hole wider when something doesn't fit it", i'd address that "something"... -- To view, visit http://gerrit.ovirt.org/29722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If670144751fdb9564380a12fb73596ecbaa47ee9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Ilia Meerovich <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
