Yair Zaslavsky has posted comments on this change. Change subject: engine : Persist commands automatically ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/31681/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 1356: /** Line 1357: * Automatically persists commands with command call backs or Line 1358: * if the command has child commands Line 1359: */ Line 1360: private void checkPersistCommand() { maybe calll this - checkAndPersist? persistIfRequired - I know the method returns "void" - but to me - a check looks like it just checks, and not performs somrthinng. Line 1361: // persist command if command provides custom callback Line 1362: if (getCallBack() != null) { Line 1363: persistCommand(getParameters().getParentCommand(), true); Line 1364: return; Line 1360: private void checkPersistCommand() { Line 1361: // persist command if command provides custom callback Line 1362: if (getCallBack() != null) { Line 1363: persistCommand(getParameters().getParentCommand(), true); Line 1364: return; i personally prefer else if over return, a matter of taste Line 1365: } Line 1366: Line 1367: // persist command if it has child commands Line 1368: if (!childCommandInfoMap.isEmpty()) { -- To view, visit http://gerrit.ovirt.org/31681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4f56ec11d295baae513e7552f93a5bf9b81d384 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
