Greg Padgett has posted comments on this change. Change subject: engine : CoCo: Add ability to register for audit log events ......................................................................
Patch Set 3: Agree with Oved, looks nice. Doesn't look like we need it for Live Merge at this point given the redesign of the recovery flows, but worth considering next time a similar problem comes along. One question I had is, are all events audit-log worthy? Passing granular information through the event channel (return values, for instance) may not necessarily constitute a log entry depending on what this is ultimately used for. Or maybe it does. :) Just something to keep in mind for future use cases. -- To view, visit http://gerrit.ovirt.org/31639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67e4c8f95dbe8c96a2e8d12c400ab922d16c81cf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
