Idan Shaby has posted comments on this change. Change subject: core: WAD should be Ignored on File Domain Disks ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/31687/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/PostZeroHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/PostZeroHandler.java: Line 17: * @param <T> The parameters type. Line 18: * @return The fixed parameters. Line 19: */ Line 20: public static <T extends StorageDomainIdParametersBase & PostZero> Line 21: T fixParametersWithSecureDeletion(T parameters) { > please rename also the methods here Done Line 22: StorageDomainStatic storageDomainStatic = Line 23: DbFacade.getInstance().getStorageDomainStaticDao().get(parameters.getStorageDomainId()); Line 24: return fixParametersWithSecureDeletion(parameters, storageDomainStatic.getStorageType().isFileDomain()); Line 25: } -- To view, visit http://gerrit.ovirt.org/31687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0df2c07282994557e149db922cc1d3a166c5aa8f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
