Michael Kublin has posted comments on this change.
Change subject: core: refactoring quota
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
Line 65: public void rollbackQuota(storage_pool storagePool, List<Guid>
quotaList) {
The code is not thread safe, can be NullPointerException if remove happens
sententiously
Line 118: if (!quotaMap.containsKey(param.getQuotaId())) {
Please move a query to DB outside Critical section
Line 148: if (isIncrease) {
Please remove unneeded doubleValue(), we have otoboxing
Line 243: } else if (storageUsagePercentage <= 100) {
Don't use AuditLogDirector.log inside critical section , AuditLogDirector.log
is writing to DB
Line 412: }
Same here not thread safe, use read write locks
--
To view, visit http://gerrit.ovirt.org/6301
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc7573082e777370cdf0b88dbe5bfedeb5d02baf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
