Hello Yair Zaslavsky,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/31928
to review the following change.
Change subject: aaa: Removing groups from users main tab
......................................................................
aaa: Removing groups from users main tab
The groups are removed from the users main tab due
to the following reasons:
1. They are presented at the users sub tab.
2. We are going to present only managed groups
later on in the patchset, as a result we would like
to remove groups column entirely from the users table
and have the group names being calculated based on the
ad_groups table and the group ids that are kept at the
users table.
If we calculate this for every user in the main users
tab we will suffer from a performeance hit.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720
Change-Id: I53119c28426e678043544105ca69d85ec9c748c1
Topic: AAA
Signed-off-by: Yair Zaslavsky <[email protected]>
---
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java
1 file changed, 1 insertion(+), 17 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/28/31928/1
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java
index cdaa278..5cfdaed 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java
@@ -81,28 +81,12 @@
namespaceColumn.makeSortable();
getTable().addColumn(namespaceColumn, constants.namespace(), "150px");
//$NON-NLS-1$
- TextColumnWithTooltip<DbUser> groupColumn = new
TextColumnWithTooltip<DbUser>() {
- @Override
- public String getValue(DbUser object) {
- StringBuilder builder = new StringBuilder();
- for (String name : object.getGroupNames()) {
- if (builder.length() > 0) {
- builder.append(","); //$NON-NLS-1$
- }
- builder.append(name);
- }
- return builder.toString();
- }
- };
- groupColumn.makeSortable(VdcUserConditionFieldAutoCompleter.GROUP);
- getTable().addColumn(groupColumn, constants.groupUser(), "150px");
//$NON-NLS-1$
-
getTable().addColumn(new TextColumnWithTooltip<DbUser>() {
@Override
public String getValue(DbUser object) {
return object.getEmail();
}
- }, constants.emailUser(), "150px"); //$NON-NLS-1$
+ }, constants.emailUser());
getTable().addActionButton(new
WebAdminButtonDefinition<DbUser>(constants.addUser()) {
@Override
--
To view, visit http://gerrit.ovirt.org/31928
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I53119c28426e678043544105ca69d85ec9c748c1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
