Allon Mureinik has posted comments on this change.
Change subject: engine: Static mock removed in gluster command tests
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
All the commands have the following block in them:
@Before
public void setup() {
MockitoAnnotations.initMocks(this);
}
Since you're using MockitoJUnitRunner, this is redundant - you can simply
remove the setup method.
Other than that: +1!
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java
Line 124: return DbFacade.getInstance().getVdsStaticDAO();
I'd use getDbFacade.getVdsStaticDAO(), but I guess it's no biggie.
--
To view, visit http://gerrit.ovirt.org/6392
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23ce2c8cedf2dbcf8a287585fee02aae8d9c2e6d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
