Barak Azulay has posted comments on this change. Change subject: aaa: search by user and groups name when added via rest-api ......................................................................
Patch Set 5: Code-Review+1 I tend to think this is actually a bug rather than a change in contract. I agree there will be a change in the returned values (= change in behavior) but this does not mean when we shouldn't fix bad behavior. Intuitively I would say I would expect that when i specify a user_name it will search for it. There is an example in the search backend that once you query free text it searches for all free text items in the DB. I assume it's an attempt to do the same in the LdapQuery search. But it looks like a wrong behaviour -- To view, visit http://gerrit.ovirt.org/31709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76c5d7647d8dff5c9f2f67e42e094e883ac2164b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
