[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: extmgr: add logging for extension load/initialize

[yzaslavs]

Hello Alon Bar-Lev,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/32024

to review the following change.

Change subject: extmgr: add logging for extension load/initialize
......................................................................

extmgr: add logging for extension load/initialize

easier to track what extension may misbehave.

Topic: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720
Change-Id: I03169863db00b5bf4ac5f827fbd0aebcf73a51f3
Signed-off-by: Alon Bar-Lev <alo...@redhat.com>
---
M 
backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java
1 file changed, 12 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/24/32024/1

diff --git 
a/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java
 
b/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java
index f8c0f47..0c56920 100644
--- 
a/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java
+++ 
b/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java
@@ -32,6 +32,8 @@
  */
 public class ExtensionsManager extends Observable {
 
+    private static final Logger logger = 
LoggerFactory.getLogger(ExtensionsManager.class);
+
     public static final ExtKey TRACE_LOG_CONTEXT_KEY = new 
ExtKey("EXTENSION_MANAGER_TRACE_LOG",
             Logger.class,
             "863db666-3ea7-4751-9695-918a3197ad83");
@@ -148,12 +150,12 @@
     }
 
     private void dumpConfig(ExtensionProxy extension) {
-        Logger logger = extension.getContext().<Logger> 
get(TRACE_LOG_CONTEXT_KEY);
-        if (logger.isDebugEnabled()) {
+        Logger traceLogger = extension.getContext().<Logger> 
get(TRACE_LOG_CONTEXT_KEY);
+        if (traceLogger.isDebugEnabled()) {
             Collection sensitive = 
extension.getContext().<Collection>get(Base.ContextKeys.CONFIGURATION_SENSITIVE_KEYS);
-            logger.debug("Config BEGIN");
+            traceLogger.debug("Config BEGIN");
             for (Map.Entry<Object, Object> entry : 
extension.getContext().<Properties>get(Base.ContextKeys.CONFIGURATION).entrySet())
 {
-                logger.debug(
+                traceLogger.debug(
                     String.format(
                         "%s: %s",
                         entry.getKey(),
@@ -161,7 +163,7 @@
                     )
                 );
             }
-            logger.debug("Config END");
+            traceLogger.debug("Config END");
         }
     }
 
@@ -210,12 +212,15 @@
                             Base.ContextKeys.PROVIDES,
                             
splitString(props.getProperty(Base.ConfigKeys.PROVIDES, ""))
                     );
+
+            logger.info("Loading extension '{}'", entry.name);
             ExtMap output = entry.extension.invoke(
                     new ExtMap().mput(
                             Base.InvokeKeys.COMMAND,
                             Base.InvokeCommands.LOAD
                             )
                     );
+            logger.info("Extension '{}' loaded", entry.name);
 
             entry.extension.getContext().put(
                     TRACE_LOG_CONTEXT_KEY,
@@ -290,12 +295,14 @@
                     extensionName));
         }
         try {
+            logger.info("Initializing extension '{}'", entry.name);
             ExtMap output = entry.extension.invoke(
                     new ExtMap().mput(
                             Base.InvokeKeys.COMMAND,
                             Base.InvokeCommands.INITIALIZE
                             )
                     );
+            logger.info("Extension '{}' initialized", entry.name);
         } catch (Exception ex) {
             log.error("Error in activating extension {}. Exception message is 
{}", entry.name, ex.getMessage());
             if (log.isDebugEnabled()) {


-- 
To view, visit http://gerrit.ovirt.org/32024
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I03169863db00b5bf4ac5f827fbd0aebcf73a51f3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches