Allon Mureinik has posted comments on this change. Change subject: core: cleanup SearchObjectAutoCompleter ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) Looks right (see minor inline issue). As Eli noted - please make sure you've thoroughly tested it. .................................................... File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java Line 111: super(); why call super? -- To view, visit http://gerrit.ovirt.org/6411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fa256469cb4da6513291283ddb8b32c3ca48f0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
