Martin Sivák has uploaded a new change for review. Change subject: Monitor should not crash when unexpected exceptions happens ......................................................................
Monitor should not crash when unexpected exceptions happens The monitor thread should report the crash to log, behave as if nothing was collected and try again in the next cycle. The unexpected exception might be triggered for example by a freshly finished migration. The guest monitor reads the /proc files that belong to the migrated process and they disappear as a result of qemu performing the post-migration cleanup. Change-Id: I318c55a3215df8ccaf4b0e2d16d1d9a3b06f9d1c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1124595 Signed-off-by: Martin Sivak <[email protected]> --- M mom/Monitor.py 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/mom refs/changes/30/32030/1 diff --git a/mom/Monitor.py b/mom/Monitor.py index 7cb0649..9c8b513 100644 --- a/mom/Monitor.py +++ b/mom/Monitor.py @@ -102,6 +102,8 @@ self._set_not_ready("Fatal Collector error: %s" % e.msg) self.terminate() return None + except Exception: + self.logger.exception("Unexpected collection error") if not set(data).issuperset(self.fields): self._set_not_ready("Incomplete data: missing %s" % \ -- To view, visit http://gerrit.ovirt.org/32030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I318c55a3215df8ccaf4b0e2d16d1d9a3b06f9d1c Gerrit-PatchSet: 1 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
