Omer Frenkel has posted comments on this change. Change subject: engine: Add an AuditLog message when VM cannot be prestarted ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/32029/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java: Line 137: boolean prestartingVmSucceeded = vdcReturnValue.getSucceeded(); Line 138: Line 139: if (!prestartingVmSucceeded) { Line 140: AuditLogableBase log = new AuditLogableBase(); Line 141: log.setVmId(vmToRunAsStateless.getId()); im still not sure if we want this message per vm that fails to run, or just once for the pool (which means just not to mention the specific vm) Line 142: log.addCustomValue("VmName", vmToRunAsStateless.getName()); Line 143: log.addCustomValue("VmPoolName", vmToRunAsStateless.getVmPoolName()); Line 144: AuditLogDirector.log(log, AuditLogType.VM_FAILED_TO_PRESTART_IN_POOL); Line 145: } -- To view, visit http://gerrit.ovirt.org/32029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab04acb1746a22627b584d70c806469a818a6c8c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
