Allon Mureinik has posted comments on this change.
Change subject: core: export/import of diskless VM/VM with no snappable
disks(#838937)
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(7 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
Line 411: }
minor: move the else up on line, together with the "}"
Line 425: EndActionOnAllImageGroups();
EndActionOnAllImageGroups is now done AFTER the vm is unlocked - is this
intentional?
Line 430: private void endCopyCollapseOps(VM vm) {
please change Ops to an entire word, to make this more readable.
Line 433: Snapshot activeSnapshot =
DbFacade.getInstance().getSnapshotDao().get(
use getSnapshotDao(), not DbFacade.getInstance().getSnapshotDao()
Line 434:
DbFacade.getInstance().getSnapshotDao().getId(vm.getId(), SnapshotType.ACTIVE));
here too.
Line 442:
vm.setSnapshots(DbFacade.getInstance().getSnapshotDao().getAllWithConfiguration(getVm().getId()));
here too.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 890
why was this removed?
--
To view, visit http://gerrit.ovirt.org/6379
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77565ffd66134b44d15f66cfdfa97422e3c11fb2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
