Daniel Erez has posted comments on this change. Change subject: webadmin: New disk model size validation should be of type long ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32051/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java: Line 221: } Line 222: Line 223: StorageType storageType = getStorageDomain().getSelectedItem() == null ? StorageType.UNKNOWN Line 224: : getStorageDomain().getSelectedItem().getStorageType(); Line 225: LongValidation sizeValidation = new LongValidation(); Maybe a better solution would be to define size as Integer? The size here is in GB so it might be confusing to allow such large values... As for block domains we limit disk size to 8TB by default any way (ConfigValues.MaxBlockDiskSize). For file domains, I don't think we can have disks larger than 2147483647GB.. Line 226: sizeValidation.setMinimum(1); Line 227: if (storageType.isBlockDomain()) { Line 228: sizeValidation.setMaximum((Integer) AsyncDataProvider.getInstance().getConfigValuePreConverted(ConfigurationValues.MaxBlockDiskSize)); Line 229: } -- To view, visit http://gerrit.ovirt.org/32051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8f6e52bc11b248fd7829261df7ec3626603e363 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
