Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: honouring engine DB parameters from answer file ......................................................................
Patch Set 2: The problem in that bug is: 1. They install with an answer file providing a custom password for the DB, it ignores it and it creates the DB with a random password 2. They cleanup 3. They install again with another answer file witch still contains the required password for the DB. Now it tries to use that password and so the engine user is not able to connect and the setup fails. I agree with you that we have to distinct and opposite approach to solve this: 1. always honoring the supplied DB password (it's what this patch tries to do) 2. always ignoring it and never write it into the answer file we are going to generate Both of them should be enough to solve it. Generally I prefer to honor all the supplied parameter (maybe just for support strange other test cases) but it's just a matter of taste. By the way we are also saving the admin password in the answer file and so I don't see any big problem saving there also the DB one. -- To view, visit http://gerrit.ovirt.org/32036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a7f79f3da05d89b34fa2cc4f74ed628fb44e3b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
