Arik Hadas has posted comments on this change. Change subject: core: use instance type values on update vm ......................................................................
Patch Set 1: Code-Review+1 (1 comment) looks good, minor comment http://gerrit.ovirt.org/#/c/31299/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java: Line 246: Line 247: protected void updateParametersVmFromInstanceType() { Line 248: InstanceType instanceType = getInstanceType(); Line 249: VmStatic vmStatic = getParameters().getVmStaticData(); Line 250: if (instanceType != null && vmStatic != null) { how about removing setInstanceTypeId(..) (and the class member maybe) and then drop the second part (vmStatic != null) ? Line 251: vmStatic.setMemSizeMb(instanceType.getMemSizeMb()); Line 252: vmStatic.setNumOfSockets(instanceType.getNumOfSockets()); Line 253: vmStatic.setCpuPerSocket(instanceType.getCpuPerSocket()); Line 254: vmStatic.setDefaultBootSequence(instanceType.getDefaultBootSequence()); -- To view, visit http://gerrit.ovirt.org/31299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3ed838af7052f744dccd015f90032fdfc18cc55 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
