Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Fix Maven build-time warnings ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32145/1/frontend/webadmin/modules/gwt-extension/pom.xml File frontend/webadmin/modules/gwt-extension/pom.xml: Line 47: </dependency> Line 48: </dependencies> Line 49: <build> Line 50: <!-- Overrides default value ${project.artifactId}-${project.version} --> Line 51: <finalName>ovirt-engine-gwt-extension-${project.version}</finalName> > According to above comment, looks like it's missing the project. part befor Yes, to reference artifactId value inside POM file, ${project.artifactId} should be used. I just updated the comment block for consistency. The issue here was that ${version} is a deprecated alias to ${project.version}. Line 52: <plugins> Line 53: <plugin> Line 54: <artifactId>maven-compiler-plugin</artifactId> Line 55: <configuration> -- To view, visit http://gerrit.ovirt.org/32145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id541ba5b01769dc5e8cab16f8260ea20b95e7270 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
