Daniel Erez has posted comments on this change. Change subject: ui, core: Return specific provider authentication error ......................................................................
Patch Set 8: Code-Review+1 (4 comments) http://gerrit.ovirt.org/#/c/31179/8//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-08-09 12:49:46 +0300 Line 4: Commit: Yaniv Bronhaim <[email protected]> Line 5: CommitDate: 2014-08-29 20:17:03 -0400 Line 6: Line 7: ui, core: Return specific provider authentication error s/ui/webadmin Line 8: Line 9: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1113000 Line 10: Change-Id: Ia8d6540b115454cfd2aa055ba711694f74855164 Line 4: Commit: Yaniv Bronhaim <[email protected]> Line 5: CommitDate: 2014-08-29 20:17:03 -0400 Line 6: Line 7: ui, core: Return specific provider authentication error Line 8: can you please elaborate on the change.. Line 9: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1113000 Line 10: Change-Id: Ia8d6540b115454cfd2aa055ba711694f74855164 http://gerrit.ovirt.org/#/c/31179/8/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties: Line 390: NO_ACTIVE_ISO_DOMAIN_IN_DATA_CENTER=There is no active ISO Domain in Data Center. Line 391: PROVIDER_FAILURE=Failed to communicate with the external provider. Line 392: PROVIDER_IMPORT_CERTIFICATE_CHAIN_ERROR=Failed to import provider certificate chain. Line 393: PROVIDER_SSL_FAILURE=SSL problem while trying to connect to the external provider. Line 394: PROVIDER_AUTHENTICATION_FAILURE=Failed to authenticate with the external provider. Please confirm username and passowrd. s/passowrd/password Line 395: FAILED_UPDATE_RUNNING_VM=Failed to update VM while it is running, please try again when the VM is Down. Line 396: VM_NOT_QUALIFIED_FOR_SNAPSHOT_MERGE=To merge snapshots, a VM must be Down, Up or Paused. Line 397: VM_HOST_CANNOT_LIVE_MERGE=The host on which this VM is running does not support live merging snapshots. Line 398: MIGRATION_DEST_INVALID_HOSTNAME=Migration destination has an invalid hostname http://gerrit.ovirt.org/#/c/31179/8/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java: Line 416: private void setTestResultValue(VdcReturnValueBase result) { Line 417: String errorMessage = EMPTY_ERROR_MESSAGE; Line 418: if (result == null || !result.getSucceeded()) { Line 419: if (result != null) { Line 420: errorMessage = Frontend.getInstance().translateVdcFault(result.getFault()); formatter Line 421: } else if ((Boolean) requiresAuthentication.getEntity() && StringHelper.isNullOrEmpty(keystoneUrl)) { Line 422: errorMessage = ConstantsManager.getInstance().getConstants().noAuthUrl(); Line 423: } else { Line 424: errorMessage = ConstantsManager.getInstance().getConstants().testFailedUnknownErrorMsg(); -- To view, visit http://gerrit.ovirt.org/31179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8d6540b115454cfd2aa055ba711694f74855164 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
