mooli tayer has posted comments on this change.

Change subject: notifier: send sysUpTime in snmp notifications.
......................................................................


Patch Set 3:

> please re-confirm that upstream formal documentation is wrong and you are 
> right[1]
>[1] http://www.snmp4j.org/doc/org/snmp4j/package-summary.html

Verified again.

Also sent email to snmp4j at agentpp.org but got no response.

I think they have a contradiction between their api and example.

Unless I'm reading it wrong this works well:
sysUpTimeInstance = Timeticks: (2110) 0:00:21.10[1]
Than when notifier sends again:
sysUpTimeInstance = Timeticks: (66354) 0:11:03.54[2]

Notice the parsing of 0:11:03.54 is done by snmp4j and not me.

[1]
2014-08-31 16:58:22 dhcp-1-204.tlv.redhat.com [UDP: 
[10.35.1.204]:45086->[10.35.0.122]:162]:
SNMPv2-MIB::snmpTrapOID.0 = OID: SNMPv2-SMI::enterprises.2312.13.1.1.0.2        
DISMAN-EVENT-MIB::sysUpTimeInstance = Timeticks: (2110) 0:00:21.10      
SNMPv2-SMI::enterprises.2312.13.1.1.0.2.0 = STRING: "Engine server is not 
responding."  SNMPv2-SMI::enterprises.2312.13.1.1.0.2.1 = STRING: "WARNING"   
SNMPv2-SMI::enterprises.2312.13.1.1.0.2.2 = STRING: "alertMessage"      
SNMPv2-SMI::enterprises.2312.13.1.1.0.2.3 = STRING: "2014-08-31 09:58:02.755"   
SNMPv2-SMI::enterprises.2312.13.1.1.0.2.4 = STRING: "VDC_STOP"

[2]
2014-08-31 17:09:05 dhcp-1-204.tlv.redhat.com [UDP: 
[10.35.1.204]:45086->[10.35.0.122]:162]:
SNMPv2-MIB::snmpTrapOID.0 = OID: SNMPv2-SMI::enterprises.2312.13.1.1.0.509      
DISMAN-EVENT-MIB::sysUpTimeInstance = Timeticks: (66354) 0:11:03.54     
SNMPv2-SMI::enterprises.2312.13.1.1.0.509.0 = STRING: "Installing Host host_01. 
Yum Status: Downloading Packages."      
SNMPv2-SMI::enterprises.2312.13.1.1.0.509.1 = STRING: "NORMAL"  
SNMPv2-SMI::enterprises.2312.13.1.1.0.509.2 = STRING: "alertMessage"    
SNMPv2-SMI::enterprises.2312.13.1.1.0.509.3 = STRING: "2014-08-31 08:59:57.268" 
SNMPv2-SMI::enterprises.2312.13.1.1.0.509.4 = STRING: "VDS_INSTALL_IN_PROGRESS" 
SNMPv2-SMI::enterprises.2312.13.1.1.0.509.7 = STRING: "host_01"

-- 
To view, visit http://gerrit.ovirt.org/31916
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f908ec8d7b9ce27bd845a568cc4ed195aafc9ab
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Martin PeÅ™ina <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to