Lior Vernia has uploaded a new change for review. Change subject: engine: Change reorder vNIC action's permissions ......................................................................
engine: Change reorder vNIC action's permissions Changed the aforementioned action to belong to ActionGroup.CREATE_VM rather than ActionGroup.CONFIGURE_VM_NETWORK, as it's an integral part of the process of creating a VM (it shouldn't be called in the context of a pre-existing VM in order to re-arrange its NICs). This might seem askew - this whole command can (and likely should) be a part of the Create VM command, if that is changed to receive as a parameter a list of NICs to create. Change-Id: Iaef9b2e9ae9258210f48b59d89467247ff9a2468 Bug-Url: https://bugzilla.redhat.com/1134554 Signed-off-by: Lior Vernia <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/32259/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java index aad58a6..a21fcc2 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java @@ -23,6 +23,7 @@ MigrateVm(14, ActionGroup.MIGRATE_VM, QuotaDependency.NONE), InternalMigrateVm(15, QuotaDependency.NONE), MigrateVmToServer(16, ActionGroup.MIGRATE_VM, QuotaDependency.NONE), + ReorderVmNics(17, ActionGroup.CREATE_VM, false, QuotaDependency.NONE), VmLogon(18, ActionGroup.CONNECT_TO_VM, QuotaDependency.NONE), SetVmTicket(22, ActionGroup.CONNECT_TO_VM, false, QuotaDependency.NONE), ExportVm(23, ActionGroup.IMPORT_EXPORT_VM, QuotaDependency.NONE), @@ -31,7 +32,6 @@ AddVmInterface(28, ActionGroup.CONFIGURE_VM_NETWORK, false, QuotaDependency.NONE), RemoveVmInterface(29, ActionGroup.CONFIGURE_VM_NETWORK, false, QuotaDependency.NONE), UpdateVmInterface(30, ActionGroup.CONFIGURE_VM_NETWORK, false, QuotaDependency.NONE), - ReorderVmNics(128, ActionGroup.CONFIGURE_VM_NETWORK, false, QuotaDependency.NONE), AddDisk(31, ActionGroup.CONFIGURE_VM_STORAGE, QuotaDependency.STORAGE), RegisterDisk(32, ActionGroup.CONFIGURE_VM_STORAGE, QuotaDependency.STORAGE), @Deprecated -- To view, visit http://gerrit.ovirt.org/32259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaef9b2e9ae9258210f48b59d89467247ff9a2468 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
