Juan Hernandez has posted comments on this change.

Change subject: packaging: Use /var/tmp instead of /var/cache
......................................................................


Patch Set 2:

Unfortunately we can't use the PID of the process to create the directory, 
because the process is created after creating the directory, and it has to be 
that way, JBoss needs the directory created.

We could use a temporary name, but that will mean that we would need to 
remember that temporary name in order to delete it when stopping, and this 
complicates things.

Runnig simultaneously is not a big risk as the Python os.mkdir(engineTmpDir) 
call uses the mkdir system call, which is atomic, so the second script to try 
to do it will fail.

There is room for improvement, sure, but I suggest we leave them for future 
changes.

--
To view, visit http://gerrit.ovirt.org/6453
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I369f1d4175674b9b784cb33e1f4e4f58ff4820bf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to