Martin Peřina has posted comments on this change. Change subject: aaa: engine-manads-domains always tries to look for KDC in DNS ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32279/1/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java: Line 581: public void editDomain() throws ManageDomainsResult { Line 582: String authMode; Line 583: String domainName = args.get(ARG_DOMAIN); Line 584: authMode = getDomainAuthMode(domainName); Line 585: validateKdcServers(authMode, domainName); Shouldn't the shouldResolveKdc() check be applied also in editDomain()? Line 586: String currentDomains = configurationProvider.getConfigValue(ConfigValues.DomainName); Line 587: String userName = args.get(ARG_USER); Line 588: DomainsConfigurationEntry domainNameEntry = Line 589: new DomainsConfigurationEntry(currentDomains, DOMAIN_SEPERATOR, null); -- To view, visit http://gerrit.ovirt.org/32279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3bb7cc049ad5b23127a505ff891b2d489a2caca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
