Tomas Jelinek has posted comments on this change. Change subject: engine: don't allow to create VM with balloon on ppc64 ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/32243/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java: Line 190: return false; Line 191: } Line 192: } Line 193: Line 194: if (getVdsGroup() != null && getVm().isBalloonEnabled() && !getVdsGroup().isBalloonSupported()) { getVdsGroup() can return null here? I think it should not and since you do not check this anywhere else I would stay consistent... Line 195: return failCanDoAction(VdcBllMessages.BALLOON_REQUESTED_ON_NOT_SUPPORTED_ARCH, Line 196: String.format("$clusterArch %1$s", getVdsGroup().getArchitecture())); Line 197: } Line 198: http://gerrit.ovirt.org/#/c/32243/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java: Line 18: Line 19: public class VDSGroup extends IVdcQueryable implements Serializable, BusinessEntity<Guid>, HasStoragePool<Guid>, Nameable, Commented { Line 20: Line 21: private static final long serialVersionUID = 5659359762655478095L; Line 22: public static final ArchitectureType BALLOON_DEVICE_BLACKLISTED_ARCH = ArchitectureType.ppc64; It seems this is not used outside of this class, please make it private. Line 23: Line 24: private Guid id; Line 25: Line 26: @NotNull(message = "VALIDATION.VDS_GROUP.NAME.NOT_NULL", groups = { CreateEntity.class, UpdateEntity.class }) Line 295: public void setEnableBallooning(boolean enableBallooning) { Line 296: this.enableBallooning = enableBallooning; Line 297: } Line 298: Line 299: public boolean isBalloonSupported(){ formatter ;) you miss a space between () and { Line 300: return this.architecture != BALLOON_DEVICE_BLACKLISTED_ARCH; Line 301: } Line 302: Line 303: public void setDetectEmulatedMachine(boolean detectEmulatedMachine) { -- To view, visit http://gerrit.ovirt.org/32243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee077b08a825e65de2cddce85bc88573e89da4ab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
