Yedidyah Bar David has posted comments on this change.

Change subject: packaging: setup: Improoving support for unattended setup
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/32292/2/packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py
File packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py:

Line 337:                     remote_engine_host = self.dialog.queryString(
Line 338:                         name='REMOTE_ENGINE_HOST',
Line 339:                         note=_(
Line 340:                             'Please provide the FQDN or IP '
Line 341:                             'of the remote engine host: '
> It works cause I'm downloading it from http and so we don't have https ssl 
On a second thought, I am not sure I can accept that. Did Alon accept that?

I already started doing the same for reports (I need there the ca cert, also 
available with a similar url), but now I think it might be better to ask the 
user to copy the ca cert manually.
Line 342:                         ),
Line 343:                         prompt=True,
Line 344:                     )
Line 345: 


-- 
To view, visit http://gerrit.ovirt.org/32292
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic20c9fc375867fdfb6d299b3d09cd7fc14d380bc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to