Omer Frenkel has posted comments on this change. Change subject: engine: don't allow to create VM with balloon on ppc64 ......................................................................
Patch Set 6: (11 comments) http://gerrit.ovirt.org/#/c/32038/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java: Line 208: } Line 209: } Line 210: Line 211: OsRepository osRepository = SimpleDependecyInjector.getInstance().get(OsRepository.class); Line 212: if (getVdsGroup() != null && getVm().isBalloonEnabled() && !osRepository.isBalloonEnabled(getVm().getStaticData().getOsId(), no need to check getVdsGroup() != null because first check in the method covers this Line 213: getVdsGroup().getcompatibility_version())) { Line 214: addCanDoActionMessageVariable("clusterArch", getVdsGroup().getArchitecture()); Line 215: return failCanDoAction(VdcBllMessages.BALLOON_REQUESTED_ON_NOT_SUPPORTED_ARCH); Line 216: } http://gerrit.ovirt.org/#/c/32038/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java: Line 732: public boolean isVirtioScsiEnabledForVm(Guid vmId) { Line 733: return VmDeviceUtils.isVirtioScsiControllerAttached(vmId); Line 734: } Line 735: Line 736: boolean isBalloonEnabled() { please make method protected Line 737: Boolean balloonEnabled = getParameters().isBalloonEnabled(); Line 738: return balloonEnabled != null ? balloonEnabled : VmDeviceUtils.isBalloonEnabled(getVmId()); Line 739: } Line 740: http://gerrit.ovirt.org/#/c/32038/6/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 91: please deactivate/detach the Disk snapshots or turn off those VMs and try again. Line 92: ACTION_TYPE_FAILED_OVF_DISK_NOT_SUPPORTED=Cannot ${action} ${type}. The operation is currently not supported for disks used as OVF store. Line 93: ACTION_TYPE_FAILED_OVF_DISK_NOT_IN_APPLICABLE_STATUS=Cannot ${action} ${type}. The operation can be performed only for OVF disks that are in ${status} status. Line 94: VDS_CANNOT_REMOVE_DEFAULT_VDS_GROUP=Cannot remove default Host Cluster. Line 95: VDS_CANNOT_REMOVE_VDS_DETECTED_RUNNING_VM=Cannot ${action} ${type}. One or more VMs are still running on this Host. please remove this noise from this patch Line 96: VDS_CANNOT_REMOVE_VDS_GROUP_VDS_DETECTED=Cannot ${action} ${type}. Host Cluster contains one or more Hosts. Line 97: VDS_CANNOT_REMOVE_VDS_STATUS_ILLEGAL=Cannot ${action} ${type}. Host is operational. Please switch Host to Maintenance mode first. Line 98: VDS_NOT_EXIST=Cannot ${action} ${type}. Internal Error: Host does not exists in DB. Line 99: CANNOT_FORCE_SELECT_SPM_VDS_NOT_UP=Cannot ${action} ${type}. The Host ${VdsName} is not active. Line 1167: ACTION_TYPE_FAILED_CLUSTER_POLICY_FILTER_NOT_IMPLEMENTED=Cannot ${action} ${type}. Policy unit doesn't implement Filtering. Line 1168: ACTION_TYPE_FAILED_CLUSTER_POLICY_FUNCTION_NOT_IMPLEMENTED=Cannot ${action} ${type}. Policy unit doesn't implement score function. Line 1169: ACTION_TYPE_FAILED_CLUSTER_POLICY_BALANCE_NOT_IMPLEMENTED=Cannot ${action} ${type}. Policy unit doesn't implement load balancing logic. Line 1170: ACTION_TYPE_FAILED_CLUSTER_POLICY_ONLY_ONE_FILTER_CAN_BE_FIRST=Cannot ${action} ${type}. Only a single filter can be selected as first. Line 1171: ACTION_TYPE_FAILED_CLUSTER_POLICY_ONLY_ONE_FILTER_CAN_BE_LAST=Cannot ${action} ${type}. Only a single filter can be selected as last. please remove this noise from this patch Line 1172: ACTION_TYPE_FAILED_CLUSTER_POLICY_FUNCTION_FACTOR_NEGATIVE=Cannot ${action} ${type}. Function factor cannot be negative. Line 1173: ACTION_TYPE_FAILED_CANNOT_REMOVE_POLICY_UNIT_ATTACHED_TO_CLUSTER_POLICY=Cannot ${action} ${type}. Policy unit is attached to the following cluster policies: ${cpNames}. Line 1174: # External Events Errors Messages Line 1175: VAR__TYPE__EXTERNAL_EVENT=$type External Event http://gerrit.ovirt.org/#/c/32038/6/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 82: VDS_CANNOT_MAINTENANCE_VM_HAS_PLUGGED_DISK_SNAPSHOT=Cannot switch the following Hosts to Maintenance mode: ${HostsList}.\nThe following VMs cannot be migrated because they have activated Disk Snapshot attached (VM/Disk Snapshots):\n\n${disksInfo}\n\nplease deactivate/detach the Disk snapshots or turn off those VMs and try again. Line 83: ACTION_TYPE_FAILED_OVF_DISK_NOT_SUPPORTED=Cannot ${action} ${type}. The operation is currently not supported for disks used as OVF store. Line 84: ACTION_TYPE_FAILED_OVF_DISK_NOT_IN_APPLICABLE_STATUS=Cannot ${action} ${type}. The operation can be performed only for OVF disks that are in ${status} status. Line 85: VDS_CANNOT_REMOVE_DEFAULT_VDS_GROUP=Cannot remove default Host Cluster. Line 86: VDS_CANNOT_REMOVE_VDS_DETECTED_RUNNING_VM=Cannot ${action} ${type}. One or more VMs are still running on this Host. please remove this noise from this patch Line 87: VDS_CANNOT_REMOVE_VDS_GROUP_VDS_DETECTED=Cannot ${action} ${type}. Host Cluster contains one or more Hosts. Line 88: VDS_CANNOT_REMOVE_VDS_STATUS_ILLEGAL=Cannot ${action} ${type}. Host is operational. Please switch Host to Maintenance mode first. Line 89: VDS_PROTOCOL_ERROR=Internal error: Host protocol error. Line 90: VDS_RESPONSE_ERROR=Internal error: Host response error Line 495: -Either activate another Storage Domain in the Data Center, or remove the Data Center. Line 496: ERROR_CANNOT_DESTROY_LAST_STORAGE_DOMAIN=Cannot destroy the master Storage Domain from the Data Center without another active Storage Domain to take its place.\n\ Line 497: -Either activate another Storage Domain in the Data Center, or remove the Data Center.\n\ Line 498: -If you have problems with the master Data Domain, consider following the recovery process described in the documentation, or contact your system administrator. Line 499: please remove this noise from this patch Line 500: ERROR_CANNOT_DESTROY_LAST_STORAGE_DOMAIN_HOST_NOT_ACTIVE=In order to complete the operation a new master Storage Domain needs to be elected, which requires at least one active Host in the Data Center.\n\ Line 501: -Please make sure one of the Hosts is active in the Data Center first. Line 502: NETWORK_VLAN_OUT_OF_RANGE=VLAN ID must be a number between 0 and 4094. Line 503: ERROR_CANNOT_ADD_STORAGE_POOL_WITHOUT_DATA_DOMAIN=Cannot attach Storage Domain.\n\ Line 513: EN_UNKNOWN_NOTIFICATION_METHOD=The Notification method is unsupported. Line 514: EN_UNSUPPORTED_NOTIFICATION_EVENT=The notification event ${eventName} is unsupported. Line 515: EN_EVENT_UP_SUBJECT_TEXT=Alert Notification. Line 516: EN_EVENT_DOWN_SUBJECT_TEXT=Issue Solved Notification. Line 517: EN_ALREADY_SUBSCRIBED=User is already subscribed to this event with the same Notification method. please remove this noise from this patch Line 518: EN_NOT_SUBSCRIBED=Cannot ${action} ${type}.User is not subscribed to this event with the given Notification method. Line 519: ACTION_TYPE_FAILED_STORAGE_DOMAIN_TYPE_ILLEGAL=Cannot ${action} ${type}. Storage Domain type not specified. Line 520: ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL=Cannot ${action} ${type}. Storage Domain format ${storageFormat} is illegal. Line 521: ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL_HOST=Cannot ${action} ${type}. Storage format ${storageFormat} is not supported on the selected host version. http://gerrit.ovirt.org/#/c/32038/6/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 91: please deactivate/detach the Disk snapshots or turn off those VMs and try again. Line 92: ACTION_TYPE_FAILED_OVF_DISK_NOT_SUPPORTED=Cannot ${action} ${type}. The operation is currently not supported for disks used as OVF store. Line 93: ACTION_TYPE_FAILED_OVF_DISK_NOT_IN_APPLICABLE_STATUS=Cannot ${action} ${type}. The operation can be performed only for OVF disks that are in ${status} status. Line 94: VDS_CANNOT_REMOVE_DEFAULT_VDS_GROUP=Cannot remove default Host Cluster. Line 95: VDS_CANNOT_REMOVE_VDS_DETECTED_RUNNING_VM=Cannot ${action} ${type}. One or more VMs are still running on this Host. please remove this noise from this patch Line 96: VDS_CANNOT_REMOVE_VDS_GROUP_VDS_DETECTED=Cannot ${action} ${type}. Host Cluster contains one or more Hosts. Line 97: VDS_CANNOT_REMOVE_VDS_STATUS_ILLEGAL=Cannot ${action} ${type}. Host is operational. Please switch Host to Maintenance mode first. Line 98: VDS_NOT_EXIST=Cannot ${action} ${type}. Internal Error: Host does not exists in DB. Line 99: CANNOT_FORCE_SELECT_SPM_VDS_NOT_UP=Cannot ${action} ${type}. The Host ${VdsName} is not active. Line 533: -Either activate another Storage Domain in the Data Center, or remove the Data Center. Line 534: ERROR_CANNOT_DESTROY_LAST_STORAGE_DOMAIN=Cannot destroy the master Storage Domain from the Data Center without another active Storage Domain to take its place.\n\ Line 535: -Either activate another Storage Domain in the Data Center, or remove the Data Center.\n\ Line 536: -If you have problems with the master Data Domain, consider following the recovery process described in the documentation, or contact your system administrator. Line 537: please remove this noise from this patch Line 538: ERROR_CANNOT_DESTROY_LAST_STORAGE_DOMAIN_HOST_NOT_ACTIVE=In order to complete the operation a new master Storage Domain needs to be elected, which requires at least one active Host in the Data Center.\n\ Line 539: -Please make sure one of the Hosts is active in the Data Center first. Line 540: NETWORK_VLAN_OUT_OF_RANGE=VLAN ID must be a number between 0 and 4094. Line 541: ERROR_CANNOT_ADD_STORAGE_POOL_WITHOUT_DATA_DOMAIN=Cannot attach Storage Domain.\n\ Line 553: EN_UNKNOWN_NOTIFICATION_METHOD=The Notification method is unsupported. Line 554: EN_UNSUPPORTED_NOTIFICATION_EVENT=The notification event ${eventName} is unsupported. Line 555: EN_EVENT_UP_SUBJECT_TEXT=Alert Notification. Line 556: EN_EVENT_DOWN_SUBJECT_TEXT=Issue Solved Notification. Line 557: EN_ALREADY_SUBSCRIBED=User is already subscribed to this event with the same Notification method. please remove this noise from this patch Line 558: EN_NOT_SUBSCRIBED=Cannot ${action} ${type}.User is not subscribed to this event with the given Notification method. Line 559: ACTION_TYPE_FAILED_STORAGE_DOMAIN_TYPE_ILLEGAL=Cannot ${action} ${type}. Storage Domain type not specified. Line 560: ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL=Cannot ${action} ${type}. Storage Domain format ${storageFormat} is illegal. Line 561: ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL_HOST=Cannot ${action} ${type}. Storage format ${storageFormat} is not supported on the selected host version. Line 1139: ACTION_TYPE_FAILED_CLUSTER_POLICY_FILTER_NOT_IMPLEMENTED=Cannot ${action} ${type}. Policy unit doesn't implement Filtering. Line 1140: ACTION_TYPE_FAILED_CLUSTER_POLICY_FUNCTION_NOT_IMPLEMENTED=Cannot ${action} ${type}. Policy unit doesn't implement score function. Line 1141: ACTION_TYPE_FAILED_CLUSTER_POLICY_BALANCE_NOT_IMPLEMENTED=Cannot ${action} ${type}. Policy unit doesn't implement load balancing logic. Line 1142: ACTION_TYPE_FAILED_CLUSTER_POLICY_ONLY_ONE_FILTER_CAN_BE_FIRST=Cannot ${action} ${type}. Only a single filter can be selected as first. Line 1143: ACTION_TYPE_FAILED_CLUSTER_POLICY_ONLY_ONE_FILTER_CAN_BE_LAST=Cannot ${action} ${type}. Only a single filter can be selected as last. please remove this noise from this patch Line 1144: ACTION_TYPE_FAILED_CLUSTER_POLICY_FUNCTION_FACTOR_NEGATIVE=Cannot ${action} ${type}. Function factor cannot be negative. Line 1145: ACTION_TYPE_FAILED_CANNOT_REMOVE_POLICY_UNIT_ATTACHED_TO_CLUSTER_POLICY=Cannot ${action} ${type}. Policy unit is attached to the following cluster policies: ${cpNames}. Line 1146: # External Events Errors Messages Line 1147: VAR__TYPE__EXTERNAL_EVENT=$type External Event -- To view, visit http://gerrit.ovirt.org/32038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee077b08a825e65de2cddce85bc88573e89da4ab Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
