Frank Kobzik has posted comments on this change. Change subject: core: Adjust websockify to the new API ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/32138/1/packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.py File packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.py: Line 209: pidfile=self.pidfile, Line 210: ) Line 211: Line 212: def daemonStdHandles(self): Line 213: consoleLog = open(os.devnull, 'w+') > when you use the python logger you should not relay on console log any more I see, so I'll leave it to go to /dev/null. But is it enough if our websocket proxy writes to syslog? About ">= 0.6": I monkeypatched the methods that are used by old websockify to use logger. (What I'm worried about is the fact I see duplicate lines in syslog - one line comes from "journal", the other one from "ovirt-websocket-proxy" and they are identical. I need to investigate this further.) Line 214: return (consoleLog, consoleLog) Line 215: Line 216: def daemonContext(self): Line 217: # Line 259: target_host=None, Line 260: target_port=None, Line 261: wrap_mode='exit', Line 262: wrap_cmd=None, Line 263: RequestHandlerClass=OvirtProxyRequestHandler > comma Done Line 264: ).start_server() Line 265: # WORKAROUND-BEGIN Line 266: # websockify exit because of signals. Line 267: # redirect it to expected termination sequence. -- To view, visit http://gerrit.ovirt.org/32138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13f94f91a1bdee0bfa93dc263de7e51395f7d7ce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
