Vojtech Szocs has posted comments on this change. Change subject: oVirt.js: Initial rewiev commit [WIP] Don't merge! ......................................................................
Patch Set 2: Great job, Martin! I really like the code improvements. Some notes: * we can (hopefully) avoid _privateFn convention by using modules -> avoid leaking impl. details into API * we can use destructuring assignment for both local variables and method parameters -> less "boilerplate" code * we can use for..of to iterate arrays instead of forEach -> simpler code * we should decide whether using let keyword is acceptable in current version of ES6 transpilers (Traceur, TypeScript), I see you avoided let keyword so far -- To view, visit http://gerrit.ovirt.org/32310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6af0fe3089d70816dc3e138fed66163af5ecb28 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
