Ravi Nori has uploaded a new change for review. Change subject: webadmin: 'Add Users and Groups' dialog the column size should be limited ......................................................................
webadmin: 'Add Users and Groups' dialog the column size should be limited The column with the long name looks long and we need to scroll right/left to see the other columns Change-Id: Ia3009bffce854cc99031ad6571affea328c437d1 Bug-Url: https://bugzilla.redhat.com/1126283 Signed-off-by: Ravi Nori <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java 1 file changed, 12 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/34/32334/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java index da34c81..663e7c4 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java @@ -44,6 +44,11 @@ ViewUiBinder uiBinder = GWT.create(ViewUiBinder.class); } + /** + * This is the max width of a column in this dialogs + */ + private static final String MAX_COL_WIDTH = "284px"; //$NON-NLS-1$ + @UiField @WithElementId public UiCommandButton searchButton; @@ -107,6 +112,7 @@ super(eventBus, resources); initListBoxEditors(); searchItems = new EntityModelCellTable<ListModel>(true); + searchItems.enableColumnResizing(); initWidget(ViewUiBinder.uiBinder.createAndBindUi(this)); generateIds(); searchStringEditor.setStyleName(""); @@ -145,26 +151,26 @@ private void initTable(CommonApplicationConstants constants) { // Table Entity Columns - searchItems.addEntityModelColumn(new EntityModelTextColumn<DbUser>() { + searchItems.addColumn(new EntityModelTextColumn<DbUser>() { @Override public String getText(DbUser user) { return user.getFirstName(); } - }, constants.firsNamePermissionsPopup()); + }, constants.firsNamePermissionsPopup(), MAX_COL_WIDTH); - searchItems.addEntityModelColumn(new EntityModelTextColumn<DbUser>() { + searchItems.addColumn(new EntityModelTextColumn<DbUser>() { @Override public String getText(DbUser user) { return user.getLastName(); } - }, constants.lastNamePermissionsPopup()); + }, constants.lastNamePermissionsPopup(), MAX_COL_WIDTH); - searchItems.addEntityModelColumn(new EntityModelTextColumn<DbUser>() { + searchItems.addColumn(new EntityModelTextColumn<DbUser>() { @Override public String getText(DbUser user) { return user.getLoginName(); } - }, constants.userNamePermissionsPopup()); + }, constants.userNamePermissionsPopup(), MAX_COL_WIDTH); } void localize(CommonApplicationConstants constants) { -- To view, visit http://gerrit.ovirt.org/32334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia3009bffce854cc99031ad6571affea328c437d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
