Sandro Bonazzola has posted comments on this change. Change subject: Update engine's mgmt net to have the correct vlan id ......................................................................
Patch Set 7: (3 comments) http://gerrit.ovirt.org/#/c/32269/7/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py: Line 430: net_info = netinfo.NetInfo(network.vds_capabilities(conn)) Line 431: bridge_port = self.environment[ohostedcons.NetworkEnv.BRIDGE_IF] Line 432: if bridge_port in net_info.vlans: Line 433: self.logger.debug('Updating engine\'s management network to ' Line 434: 'be vlanned') > ')' in own line self.logger.debug( 'Updating engine\'s management network to ' 'be vlanned' ) Line 435: vlan_id = net_info.vlans[bridge_port]['vlanid'] Line 436: mgmt_network = engine_api.networks.get( Line 437: name=self.environment[ohostedcons.NetworkEnv.BRIDGE_NAME] Line 438: ) Line 436: mgmt_network = engine_api.networks.get( Line 437: name=self.environment[ohostedcons.NetworkEnv.BRIDGE_NAME] Line 438: ) Line 439: mgmt_network.set_vlan( Line 440: self._ovirtsdk_xml.params.VLAN(id=vlan_id)) > last ')' in own line yep Line 441: mgmt_network.update() Line 442: Line 443: self.logger.debug('Adding the host to the cluster') Line 444: cluster_name = self.environment[ http://gerrit.ovirt.org/#/c/32269/7/src/plugins/ovirt-hosted-engine-setup/network/bridge.py File src/plugins/ovirt-hosted-engine-setup/network/bridge.py: Line 200: networks = { Line 201: self.environment[ohostedcons.NetworkEnv.BRIDGE_NAME]: Line 202: network.net_info( Line 203: network.vds_capabilities(conn), Line 204: self.environment[ohostedcons.NetworkEnv.BRIDGE_IF])} > Is there some style guide for ovirt-hosted-engine? In vdsm we just use pep8 No style guide, maybe we need to write one. Line 205: _setupNetworks(conn, networks, {}, {'connectivityCheck': False}) Line 206: _setSafeNetworkConfig(conn) Line 207: Line 208: @plugin.event( -- To view, visit http://gerrit.ovirt.org/32269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica4c5804395d364438f1e142387376cc7adc7172 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
