Artyom Lukianov has uploaded a new change for review. Change subject: Add additional exception to prevent socket.gaierror error ......................................................................
Add additional exception to prevent socket.gaierror error In time of second host, you need to pass FQDN of first host to receive answer file, but FQDN not pass any validation and can be incorrect, it will lead to socket.gaierror in socket.getaddrinfo method. Change-Id: I92776791af606b6fdb664c9e44ed119a167d15ac Signed-off-by: Artyom Lukianov <[email protected]> --- M src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-hosted-engine-setup refs/changes/92/32392/1 diff --git a/src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py b/src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py index 1b6b07b..364826c 100644 --- a/src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py +++ b/src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py @@ -25,6 +25,7 @@ import gettext import os import paramiko +import socket import tempfile @@ -72,7 +73,7 @@ ohostedcons.FirstHostEnv.FQDN ], 22)) valid = True - except paramiko.SSHException as e: + except (paramiko.SSHException, socket.gaierror) as e: self.logger.debug('exception', exc_info=True) if fqdn_interactive: self.logger.error( -- To view, visit http://gerrit.ovirt.org/32392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I92776791af606b6fdb664c9e44ed119a167d15ac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
