Allon Mureinik has posted comments on this change. Change subject: core: ImportVmCommand storage space allocations ......................................................................
Patch Set 7: Code-Review+1 (2 comments) Other than the issue I have with the naming, looks good. http://gerrit.ovirt.org/#/c/32258/7//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-09-01 08:57:26 +0300 Line 4: Commit: Vered Volansky <[email protected]> Line 5: CommitDate: 2014-09-03 16:28:16 +0300 Line 6: Line 7: core: ImportVmCommand storage space allocations s/allocations/allocation checks/ Line 8: Line 9: Replace existing storage allocation validations with new, correct Line 10: validations. Also amended and added tests. Line 11: http://gerrit.ovirt.org/#/c/32258/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java: Line 816: } Line 817: return snapshot; Line 818: } Line 819: Line 820: public static DiskImage createDummyDiskImage(DiskImage diskImage, Guid sdId) { this needs a better name - the context is not clear here. Line 821: DiskImage dummy = DiskImage.copyOf(diskImage); Line 822: dummy.setStorageIds(new ArrayList<Guid>(Collections.singletonList(sdId))); Line 823: dummy.getSnapshots().addAll(ImagesHandler.getAllImageSnapshots(dummy.getImageId())); Line 824: return dummy; -- To view, visit http://gerrit.ovirt.org/32258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbb1d985f9afa476452d1d2b78be1fd18c128c8f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
