Daniel Erez has posted comments on this change. Change subject: webadmin: changeing vm_type and os_type did reset the dialog ......................................................................
Patch Set 4: Code-Review+2 (3 comments) http://gerrit.ovirt.org/#/c/31892/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java: Line 1114: } Line 1115: Line 1116: public void vmTypeChanged(VmType vmType) { Line 1117: if (basedOnCustomInstanceType()) { Line 1118: // this field is normally taken from instance type. If the "custom" is selected, than it is supposed to use the default typo: s/than/then Line 1119: // determined by vm type Line 1120: getModel().getIsSoundcardEnabled().setEntity(vmType == VmType.Desktop); Line 1121: } Line 1122: http://gerrit.ovirt.org/#/c/31892/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java: Line 146: doUpdateManagedFieldsFrom(getSource()); Line 147: } Line 148: Line 149: public void updateFildsAfterOsChanged() { Line 150: model.startProgress(null); this start/stop progress mechanism seems generic enough (and useful...), can it be extracted to some helper method? Line 151: deactivate(new ActivatedListener() { Line 152: @Override Line 153: public void activated() { Line 154: model.stopProgress(); http://gerrit.ovirt.org/#/c/31892/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/NewVmInstanceTypeManager.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/NewVmInstanceTypeManager.java: Line 24: } Line 25: } Line 26: Line 27: @Override Line 28: protected void updateBalloon(VmBase vmBase, boolean continueWithNext) { seems identical to the method in NewPoolInstanceTypeManager, logic should be extracted to parent.. Line 29: if (!isSourceCustomInstanceTypeOrBlankTemplate()) { Line 30: super.updateBalloon(vmBase, continueWithNext); Line 31: } else if (continueWithNext) { Line 32: updateRngDevice(vmBase); -- To view, visit http://gerrit.ovirt.org/31892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5859ca02ddcbeb60583a0e79b94f7b9f2647596a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
