Tal Nisan has posted comments on this change. Change subject: core: Added tests for validation on managed custom mount option ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/32373/4/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommandTest.java: Line 26: conn.setstorage_type(storageType); Line 27: conn.setMountOptions(mountOptions); Line 28: return conn; Line 29: } Line 30: > General - all these tests look exactly the same - consider extracting a com Done Line 31: @Test Line 32: public void testPosixConnectionWithInvalidMountOptions() { Line 33: StorageServerConnections conn =createConnection(StorageType.POSIXFS, "timeo=30, vfs_type=nfs"); Line 34: params.setStorageServerConnection(conn); Line 32: public void testPosixConnectionWithInvalidMountOptions() { Line 33: StorageServerConnections conn =createConnection(StorageType.POSIXFS, "timeo=30, vfs_type=nfs"); Line 34: params.setStorageServerConnection(conn); Line 35: ValidationResult result = command.validateMountOptions(); Line 36: assertFalse(result.isValid()); > Please use assertThat (result, failsWith(NAME_OF_FAILURE)) Done Line 37: } Line 38: Line 39: @Test Line 40: public void testNfsConnectionWithInvalidMountOptions() { Line 54: } Line 55: Line 56: @Test Line 57: public void testNfsConnectionWithValidMountOptions() { Line 58: StorageServerConnections newPosixConnection = createConnection(StorageType.NFS, "timeo=30, validoption=666"); > timeo should be managed... Done Line 59: params.setStorageServerConnection(newPosixConnection); Line 60: ValidationResult result = command.validateMountOptions(); Line 61: assertTrue(result.isValid()); Line 62: } -- To view, visit http://gerrit.ovirt.org/32373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I678e116b8a534b69f87be59f9be8813b08cb6910 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
